fix: update make targets and docs #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caseyw
changed the title
acramsay
approved these changes
Feb 8, 2024
adrielp
reviewed
Feb 9, 2024
adrielp
requested changes
Feb 9, 2024
adrielp
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working on #openo11y docs, and wanted to view the changes before pushing.
The readme lists three steps, but having worked with mkdocs before I just wanted to simply serve. I thought running
make install-deps servewould suffice in surfacing up the docs.Instead, I saw:
The command
make install-depsinfers it will install the dependencies, butmkdocsaren't included. I found it in the Poetry config, and realized I needed to build the static assets, or use a target the README didn't reference.I structured the Makefile slightly differently, and now the install deps target works to install both.